enh: added assert_matches and assert_not_matches, fixes Issue 80 #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done, thanks for the pull request and doing all the boilerplate ;-) |
Contributor
Author
|
Added a small cosmetic fix, renamed local variable |
Member
|
Thanks @poWer4aiX excellent work. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stuertz has provided a code fragment to provide an
assert_matchesassertion in the description of issue #80. There was no pull request yet, so I have included the code now intobash_unitand added the counterpartassert_not_matchesas well. Tests have been added totests/test_core.shfor both assertions. The documentation inREADME-adochas been extended by the two new assertions, including the corresponding tests.Many thanks to Jan for his initial contribution, this was a missing assertion I currently was looking for.